Conversation
qinyiqun
changed the title
wooway777
reviewed
Mar 18, 2026
PanZezhong1725
requested changes
Mar 19, 2026
python/infinilm/cache/cache.py
Outdated
| def __init__(self, max_batch_size: int = 1, max_cache_len: int = 0): | ||
| _infinilm.StaticKVCacheConfig.__init__(self, max_batch_size, max_cache_len) | ||
|
|
||
| def __init__(self, max_batch_size: int = 1, max_cache_len: int = 0, kv_cache_dtype: str | None = None): |
Collaborator
There was a problem hiding this comment.
最好额外提供一个支持框架内dtype的接口，并在python里提供parse映射，让使用python的用户可以通过进入python文件看到各个字符串的含义
Contributor
Author
There was a problem hiding this comment.
vllm中在flash attention前都使用字符串，所以使用字符串我感觉问题不大，有注明即可
PanZezhong1725
requested changes
Mar 19, 2026
…quant.cpp; (2)update kv_cache_dtype handling; (3)Update Python test scripts
wooway777
approved these changes
Mar 20, 2026
PanZezhong1725
force-pushed
the
Issue/253
branch
2 times, most recently
from
203620f to
ae78252
Compare
PanZezhong1725
force-pushed
the
Issue/253
branch
from
ae78252 to
788532e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support offline int8 kv cache quantization for static kv cache